EOL / deprecated_eol_php_code

Encyclopedia of Life
http://eol.org/
Other
5 stars 7 forks source link

Save crop locations guid fix #119

Closed hyanwong closed 9 years ago

hyanwong commented 9 years ago

As discussed with Jeremy Rice (email below)

Note that these changes have not been tested extensively, as they require a working copy of the data_objects table, do be able to find other data objects with the same guid. I do not have a copy of this table, so this code should be tested on a trial system first.

== Context == Objects like this

http://eol.org/data_objects/31641616

seem to have multiple revisions. After each revision, it is reharvested with a different data_objID, and loses the crop info (I’ve had to recrop this particular photo multiple times, and I think other people have too, every time it is reharvested. My code applies the same crop if an object is reharvested with the same data_obID, but not otherwise. I assume I need to be reapplying the crop for the “same” objects even if they don’t have the same ID.

hyanwong commented 9 years ago

On 29 Jan 2015, at 09:05, AmrMMorad notifications@github.com wrote:

Merged #119.

Is this code running at the moment? Currently, it appears that when I first crop an image on EoL, I get “sorry this image could not be cropped”. If I then try again, it succeeds. I suspect there might be a bug in my code. Could you check the error logs?

Yan=