EOL / tramea

A lightweight server for denormalized EOL data
Other
2 stars 1 forks source link

Bug: Unpublished images cannot be curated but are featured in media collection #318

Open KatjaSchulz opened 8 years ago

KatjaSchulz commented 8 years ago

The Phyllosticta minima media collection has 2 images in it: http://eol.org/pages/194658/media

They are visible to the public, i.e., I can see them when I am logged out. I want to curate them because they are misidentified. However, when I click through to the data object pages, it says "This image is unpublished." http://eol.org/data_objects/28722088 http://eol.org/data_objects/29296979

Unpublished images should not be featured in media collections.

hyanwong commented 8 years ago

But make sure that these are not actually deleted from the system. There have been issues where e.g. people have changed the license tags on Flickr to an incompatible license (often by mistake), meaning that a whole load of images on EoL become unpublished. EoL can (presumably) still distribute these pictures, since they were originally released under a compatible license. And it would be annoying if they were to vanish from the system entirely, although I can see the rationale for hiding them from normal users.

There is then the question of whether to make them visible via the API too.

KatjaSchulz commented 8 years ago

I think "unpublished" should mean hidden from the API, too. However, we should change the way we handle Flickr images. CC licenses are not revocable, so we can legally hang on to these images. Somebody just thought it was a good idea not to. I'd like to change that in Tramea. Removal from the group or changing the license should not result in them getting "unpublished," and I think we should resurrect all the images that got unpublished in this way.