Socket close statement missing in 2 files.

EONRaider / blackhat-python3

Source code for the book "Black Hat Python" by Justin Seitz. The code has been fully converted to Python 3, reformatted to comply with PEP8 standards and refactored to eliminate dependency issues involving the implementation of deprecated libraries.

2.02k stars 414 forks source link

Socket close statement missing in 2 files. #8

Closed Galen-dp closed 3 years ago

Galen-dp commented 3 years ago

Hi. I have been comparing your code with other python 3 rewrites and the code in the prerelease pdf for the new 2nd edition of Black Hat Python. I noticed that in your chapter 2 versions of the udp-client.py and tcp-client.py files you don't call client.close() at the end of the file. I know the call is technically not needed as this programs are ending anyway. However since they are intended to be examples of how to write network code shouldn't the client.close() still be included?

EONRaider commented 3 years ago

Thanks for reporting that. I just issued a fix in this commit