Warning flag for retrieving block_num 1

EOS-Nation / bpvalidate

Tools to validate BPs have set up their public configuration correctly

MIT License

20 stars 19 forks source link

Warning flag for retrieving block_num 1 #39

Closed DenisCarriere closed 5 years ago

DenisCarriere commented 5 years ago

Fetching first block only applies for nodeos with full block synced, for nodes that use snapshots wouldn't have all blocks.

Shouldn't this be a warning and not an error?

invalid block one, value=<400 Bad Request>, field=<node[0].api_endpoint>, having node_type=, api_url=http://api.moonxwitheos.com:8888/v1/chain/get_block, post_data=<{"block_num_or_id": "1", "json": true}>

matthewdarwin commented 5 years ago

Correct... this is why the check is there. BP's API nodes should always have all the blocks, IMO. Why do you think it is OK for API to not have them?