search

EOS-uiux-Solutions / eos-icons-landing

EOS Icons website
https://eos-icons-frontend-1t6flcbwl-eos-icons.vercel.app/
MIT License
19 stars 20 forks source link

Added toast msg feature #116

Closed StarTrooper08 closed 2 years ago

StarTrooper08 commented 2 years ago

Added toast msg feature Demo SS:

The toast msg pops up in the upper center position of the window

toastmsg2SS

Abhirup-99 commented 2 years ago

We are already using react-toastify, can you try with that?

StarTrooper08 commented 2 years ago

Even using that I have added the feature before (now it's closed)but if I create PR again it will probably create merge conflict. First PR I have created using toastify package but after I have gone through this https://github.com/EOS-uiux-Solutions/eos-icons-landing/pull/71 discussion and did the required changes using react-hot-toast. I can create PR again for the following issue using toastify package. Please share your thoughts on the following @Abhirup-99

cyntss commented 2 years ago

@StarTrooper08 @Abhirup-99 for consistency reasons (among others discussed in #71 ) let's proceed with react-hot-toast.

cyntss commented 2 years ago

@Abhirup-99 can you review this PR code? I've tested the UI and everything works as expected. So final word on you!

Also, if you merge this PR, would you please close #71 ? I think they are both working on the same feature and at this point, I prefer to merge whichever fixes the issue faster. Both PRs will be valid for GSoC anyways.

StarTrooper08 commented 2 years ago

Ok :+1: @cyntss And PR is ready for the following issue using the react-hot-toast package.

Abhirup-99 commented 2 years ago

@StarTrooper08 the code looks great, but can you move the toaster component to the top level. This would allow more reuse of the toast component.

cyntss commented 2 years ago

@Abhirup-99 I would like to merge this PR. Can you add an issue with your suggestions to improve the toaster?