search

EOS-uiux-Solutions / eos-icons-landing

EOS Icons website
https://eos-icons-frontend-1t6flcbwl-eos-icons.vercel.app/
MIT License
19 stars 20 forks source link

Feature Request: Github Action for preview deployments #130

Open sarthakkundra opened 2 years ago

sarthakkundra commented 2 years ago

Is your feature request related to a problem? Please describe.

A lot of times people have to add screenshots/videos for their UI changes in their PRs for the maintainers to verify their changes. This is quite error-prone as maintainers can't check for responsiveness among a lot of other things.

Describe the solution you'd like.

A Github action to deploy all PRs to a preview vercel subdomain which will allow maintainers to easily view and verify changes.

Describe alternatives you've considered

A kubernetes cluster which will deploy on EOS's subdomain but that'll be a ton of work and not that fruitful.

Additional context.

This will also allow us to build on top later on wherein we can check performance changes made on each pull request.

ayushsatyam146 commented 2 years ago

I think the react-preview app might also be considered here. It needs to be configured once by someone with access to repo but after that, we can get separate preview links for every PR and commit by just putting a comment under the PR. App link - https://github.com/apps/react-preview

sarthakkundra commented 2 years ago

@ayushsatyam146 I think this is good for smaller projects but not that customizable in the long run. Would be better to go with a proper deployment service like Vercel, Heroku, etc. What do you think?