search

EOS-uiux-Solutions / eos-icons-landing

EOS Icons website
https://eos-icons-frontend-1t6flcbwl-eos-icons.vercel.app/
MIT License
19 stars 20 forks source link

Redesigned website footer #132

Open sarthakkundra opened 2 years ago

sarthakkundra commented 2 years ago

Closes #36

sarthakkundra commented 2 years ago

@vinayaksh42 I see the build being failed due to a failed SaSS check. Is there a particular guide / readMe setup which can guide me through the org's practices?

CC :- @cyntss

vinayaksh42 commented 2 years ago

@sarthakkundra you can check out this wiki from gitlab https://gitlab.com/eos-solutions/eos-icons-landing/-/wikis/home#writing-code

vinayaksh42 commented 2 years ago

@sarthakkundra you can check out this wiki from gitlab https://gitlab.com/eos-solutions/eos-icons-landing/-/wikis/home#writing-code

@cyntss I am unable to find the old SaSS documentation, has it been moved to a different link?

StarTrooper08 commented 2 years ago

Possibly this could help npm run test:sass.

StarTrooper08 commented 2 years ago

Reference PR https://github.com/EOS-uiux-Solutions/user-story/pull/186 Even I was getting the same build error. I solved it by running the above command which gets me the error logs. After that did the required changes accordingly.

kaybhutani commented 2 years ago

@sarthakkundra can you attach some screenshots?

sarthakkundra commented 2 years ago

@kbhutani0001 screenshot of the lint error or the footer? Because the failing lint check was fixed I guess

kaybhutani commented 2 years ago

@kbhutani0001 screenshot of the lint error or the footer? Because the failing lint check was fixed I guess

footer