EOS-uiux-Solutions / eos-icons-landing

EOS Icons website
https://eos-icons-frontend-1t6flcbwl-eos-icons.vercel.app/
MIT License
20 stars 20 forks source link

Added UI Improvements #51

Closed AnshumanDhiman closed 2 years ago

AnshumanDhiman commented 2 years ago

Fixed #48 Added various UI improvements including reduced spacing in AboutPage, Re-positioning button in the Docs Section and hiding the theme switch for Animated Icons as they are not currently available.

for hiding the theme switch I have to set the visibility criteria as when I am trying to set it by the pre-added use states, then it is creating issues.

change1 This was the bug I encountered with the select multiple toggle switch while using pre-added use state, I also tried creating a new state but also same problem.

https://user-images.githubusercontent.com/67755381/154836872-33b497db-d219-4030-b3fd-ae9152c75bb9.mp4

When I used visibility, then it worked fine as shown below. change2

https://user-images.githubusercontent.com/67755381/154836945-92b35399-e5bd-4ffc-a67c-bef80455c3b0.mp4

AnshumanDhiman commented 2 years ago

I have reviewed the code. The disable status for theme switch cannot be implemented in a straight way. As we know that the (disabled) can only be used in these tags mentioned ele The toggle button which gets set to disable once user switches from static to animated icons is also created using input tag so it can be disabled, but Switch Theme is created using spans and divs so disable cannot be implemented. We can only set its pointer properties to none so that it can't change as mentioned in the video below.

https://user-images.githubusercontent.com/67755381/155370903-7f22ae7f-aff7-4691-87f8-06468853134a.mp4

But it is not suggested as it will not hide or disable just it disables the pointer.

One thing we can do is add custom CSS which may look-alike disabled for the theme switch. We can implement this or we can let it hidden. Kindly suggest me in which way I should go forward. In this commit the visibilty hidden method is implemented.