search

EOS-uiux-Solutions / eos-icons-landing

EOS Icons website
https://eos-icons-frontend-1t6flcbwl-eos-icons.vercel.app/
MIT License
19 stars 20 forks source link

Separated the copy component and added functionality to copy code in the docs section #73

Closed AnshumanDhiman closed 2 years ago

AnshumanDhiman commented 2 years ago

Fixed #39 Created a new PR, the old PR 42 was creating issues of conflicting, as discussed with @kbhutani0001 I have created a new file.

vinayaksh42 commented 2 years ago

@AnshumanDhiman is this PR same as https://github.com/EOS-uiux-Solutions/eos-icons-landing/pull/42?

AnshumanDhiman commented 2 years ago

yes sir both the PR's are same, I was facing conflicting issues with the old PR and after force push it didn't meet up the expected changes. I had a conversation with Kartikey sir regarding this issue to open a new PR regarding this issue.

vinayaksh42 commented 2 years ago

yes sir both the PR's are same, I was facing conflicting issues with the old PR and after force push it didn't meet up the expected changes. I had a conversation with Kartikey sir regarding this issue to open a new PR regarding this issue.

Can you close your previous PR if it is no longer required?

AnshumanDhiman commented 2 years ago

sure sir

cyntss commented 2 years ago

@AnshumanDhiman always think about the scalability of your applications. All solutions need to be thought to not introduce human error when maintenance, new releases, new features come into play.

Make sure your components are ready to be re-used. Make sure your data has 1 true source. Consider new actors that don't know the codebase and how they will scale or integrate with your applications.

AnshumanDhiman commented 2 years ago

@AnshumanDhiman always think about the scalability of your applications. All solutions need to be thought to not introduce human error when maintenance, new releases, new features come into play.

Make sure your components are ready to be re-used. Make sure your data has 1 true source. Consider new actors that don't know the codebase and how they will scale or integrate with your applications.

Thank you for your feedback, I will surely work on this and I will try from next time this thing won't happen again.

cyntss commented 2 years ago

@AnshumanDhiman can you merge master into your branch to refresh it? if you get too many conflicts, feel free to close this PR and start a new one too. Whatever is the easiest for you

AnshumanDhiman commented 2 years ago

As I am having conflict issues here the code also have been updated far, I think I must close this PR and create a new PR on this. Thanks for helping😀