EOSC-synergy / SQAaaS

6 stars 1 forks source link

no image or build context for hadolint service #48

Closed ldelcano closed 2 years ago

ldelcano commented 2 years ago

Hi, I am trying to run the same pipeline I have been trying for the last months but now I get a strange error that did not appear before:

I can see that now there is a tool hadolint but since I am not sure how to use it I am still using the COMMANDS tool as you showed in the video tutorial (it worked before, I had problems cause image is to big and timeout and other things but never complained about hadolint image before)

sorry to bother you again and merry Christmas!

orviz commented 2 years ago

Fixed in https://github.com/EOSC-synergy/sqaaas-api-server/pull/155

orviz commented 2 years ago

@ldelcano your input is really good for us, no doubt you deserve a gold badge for detecting issues! :1st_place_medal:

Just fixed this one, so in principle you should be able to create the pipeline as usual. As you point out, hadolint tool is available in the dropdown list of QC.Sty criterion, so you can use it even without defining/providing a service for it (this is handled by SQAaaS). Hopefully the screenshot below clarifies its usage:

image

Thanks again!

ldelcano commented 2 years ago

Thanks Pablo, I have tried both ways and I get this error:

Using hadolint criteria without hadolint service: https://jenkins.eosc-synergy.eu/job/eosc-synergy-org/job/ScipionCloud-worker.sqaaas/job/master/18/console

Using commands criteria with a hadolint service: https://jenkins.eosc-synergy.eu/job/eosc-synergy-org/job/ScipionCloud-worker.sqaaas/job/master/19/console

OCI runtime exec failed: exec failed: container_linux.go:380: starting container process caused: exec: "h": executable file not found in $PATH: unknown

orviz commented 2 years ago

@ldelcano In your first try you used the service scipion-worker, which does not contain the hadolint command, that's why the pipeline failed. Generally speaking, when selecting a specific tool from the dropdown list, you are no longer asked to provide a service for running the tool (and this statement also includes commands). The SQAaaS selects a Docker image for you, still we left the service selection dropdown list for those cases where you want to use your own Docker image. So in this example, you can either leave unselected the service or use a custom Docker image with the tool, such as your scipion-hadolint. Appreciate if you can test it again.

Regarding the second try, the failure is once again on the SQAaaS side. Just fixed this one, thanks again for reporting this!

ldelcano commented 2 years ago

Image is being now build. Thanks.