search

EOSC-synergy / sqaaas-tooling

Hosts SQA composer templates
GNU Lesser General Public License v3.0
1 stars 6 forks source link

QC.Sty: Javascript files complaint is not being checked correctly #108

Open rjdmartins opened 2 years ago

rjdmartins commented 2 years ago

We have done an online assessment to WORSICA, and we noticed this:

This is the command that does the check:

( cd github.com/WORSICA/eosc-worsica-frontend && npx stylelint */.vue )

We do not understand why is it checking .vue files, since WORSICA has .js files. Also, it should not be a desired requirement, since not all projects do have Javascript/VUE files. Our suggestion to fix this is by verifying before if repository has .vue files or .js files in order to do that check.

rjdmartins commented 1 year ago

As I mentioned, this check must be applied if the repository has Javascript files.

Jenkins output below for eosc-worsica-frontend:

Link to Jenkins: https://jenkins.eosc-synergy.eu/job/eosc-synergy-org/job/eosc-worsica-frontend.assess.sqaaas/job/main/10/execution/node/124/log/?consoleFull

docker-compose -f .sqa/docker-compose.yml --project-directory /jenkins/workspace/sica-frontend.assess.sqaaas_main/ exec -T qc.sty_skanky-maroon-chihuahua /usr/bin/env sh .sqa/script.cheeky-peach-cheetah.sh Error: ENOENT: no such file or directory, open '/sqaaas-build/github.com/WORSICA/eosc-worsica-frontend/root/.stylelintrc.json' npm notice npm notice New major version of npm available! 8.19.2 -> 9.1.1 npm notice Changelog: https://github.com/npm/cli/releases/tag/v9.1.1 npm notice Run npm install -g npm@9.1.1 to update! npm notice