search

EOSC-synergy / sqaaas-web

Software Quality Assurance as a Service (SQAaaS) Web
https://sqaaas.eosc-synergy.eu
GNU General Public License v3.0
2 stars 3 forks source link

Why Docker registry url asked when building #161

Open orviz opened 2 years ago

orviz commented 2 years ago

In the step 2 of the Pipeline as a Service, when defining a service that will be built from a Dockerfile, the field Docker registry URL (optional) is displayed. Don't remember why this is there, since in pushing to the registry is selected, this registry can be defined as part of the image name

dianamariand92 commented 2 years ago

@orviz In the spec in services -> image -> registry we have the url parameter, that is why the Docker registry URL (optional) is displayed. If is not need it I can remove it.

orviz commented 2 years ago

@dianamariand92 I think we can remove this field yes. The registry URL is only needed when pulling or pushing, and at this point it's building. If as an additional step one wants to push the resultant image (enabling Would you like to push the Docker image to a registry?), the registry can be set as part of the Docker image value