EOSIO / eos

An open source smart contract platform
https://developers.eos.io/manuals/eos
MIT License
11.28k stars 3.6k forks source link

cleos sign command does not send the correct data #10104

Open eosauthority opened 3 years ago

eosauthority commented 3 years ago

There seems to be an issue with cleos sign command

cleos version full v2.1.0-rc3-19ac0bf5ad1f6a917f51974ff3227022b2301ed9

It does not send the correct data to be signed.

Steps 1) Create a transaction cleos -u https://api.jungle3.alohaeos.com push transaction '{"delay_sec":0,"actions":[{"account":"eosio","name":"voteproducer","data":{"voter":"streamgood12","proxy":"","producers":["lioninjungle"]},"authorization":[{"actor":"streamgood12","permission":"active"}]}]}' -d > jungle_tx.json

2) Pack the transaction for signing cleos -u https://api.jungle3.alohaeos.com convert pack_transaction --pack-action-data jungle_tx.json > jungle_packed_tx.json

3) Sign the transaction cleos --print-request -u https://api.jungle3.alohaeos.com sign --public-key EOS72YpnxKDppvMPzWAHbj5UcXBxhWBAQxCQkvYoyCQbk2YrvhtDK jungle_packed_tx.json

Issue with the REQUEST here, incorrect data is being sent for signing on printing the request.

REQUEST:

POST /v1/wallet/sign_transaction HTTP/1.1 Host: /home/ubuntu/eosio-wallet/keosd.sock: content-length: 563 Accept: / Connection: close

[{ "expiration": "1970-01-01T00:00:00", "ref_block_num": 0, "ref_block_prefix": 0, "max_net_usage_words": 0, "max_cpu_usage_ms": 0,

There is no problem packing and unpacking the Tx. The same values are retained and displayed.

heifner commented 3 years ago

cleos version full v2.1.0-rc3-19ac0bf5ad1f6a917f51974ff3227022b2301ed9

eosauthority commented 3 years ago

Confirmed same issue exists on 2.0.9

cleos version full v2.0.9-58f90b9666dc37cf35eac5dafb6db1c4138024e7