EOSIO / eos

An open source smart contract platform
https://developers.eos.io/manuals/eos
MIT License
11.29k stars 3.6k forks source link

fixing flakiness in voting and forked chain tests 📦 #11022

Closed heifner closed 2 years ago

heifner commented 2 years ago

Change Description

Fixes:

  1. nodeos_voting_lr_test. It was broken after bugfix in Node.waitForIrreversibleBlock where it was waiting for head instead of lib. After fix this increased execution time and lead to timeout fails.
  2. nodeos_forked_chain_lr_test. It had flakiness due to race condition in head catchup and switching forks that lead to go_away_message being sent with status benign_other due to unknown block requested. Fix adding retry after closing connection.

https://github.com/EOSIO/eos/pull/10381

Change Type

Select ONE:

Testing Changes

Select ANY that apply:

Consensus Changes

API Changes

Documentation Additions