The --return-failure-trace option was introduced along with the --read-only option on cleos push transaction and was exclusive to read-only transaction processing. This extends support to normal transactions. It also renames the push_ro_transaction RPC API in nodeos to send_ro_transaction to better reflect the processing it actually does, which is consistent with send_transaction rather than push_transaction.
The macro-based URL dispatcher in nodeos required extension to support differing parameter versions. To minimize the disruption to the macro, the _v1 suffix was propagated to all previously unversioned asynchronous RPC API parameter names.
backport of #10533
In addition to original PR there are 2 changes:
--return-failure-trace is enabled by default
--return-failure-trace is added for any transaction. Not just cleos push transaction but things like cleos add contract, etc. Essentially everything that results in pushing transaction.
Change Type
Select ONE:
[ ] Documentation
[ ] Stability bug fix
[x] Other
[ ] Other - special case
Testing Changes
Select ANY that apply:
[ ] New Tests
[ ] Existing Tests
[ ] Test Framework
[ ] CI System
[ ] Other
Consensus Changes
[ ] Consensus Changes
API Changes
[x] API Changes
Nodeos now responds to a new RPC API /v2/chain/send_transaction. This API requires two arguments: a boolean indicating whether or not to return failure traces, defaulting to true, and a signed transaction. Because this is a breaking change, /v1/chain/send_transaction has been preserved and still accepts solely a signed transaction.
Documentation Additions
[x] Documentation Additions
Cleos support for the push transaction command now defaults to using the new /v2/chain/send_transaction RPC API. It previously accepted an option--use-old-rpc to switch to /v1/chain/push_transaction. That option has now been supplemented with the option --use-old-send-rpc to switch to /v1/chain/send_transaction. Those two options are mutually exclusive. Neither --read-only nor --return-failure-trace can be used with either --use-old-rpc or --use-old-send-rpc.
dimas1185
commented
2 years ago
Change Description
The
--return-failure-traceoption was introduced along with the--read-onlyoption oncleos push transactionand was exclusive to read-only transaction processing. This extends support to normal transactions. It also renames thepush_ro_transactionRPC API in nodeos tosend_ro_transactionto better reflect the processing it actually does, which is consistent withsend_transactionrather thanpush_transaction.The macro-based URL dispatcher in nodeos required extension to support differing parameter versions. To minimize the disruption to the macro, the
_v1suffix was propagated to all previously unversioned asynchronous RPC API parameter names.backport of #10533
In addition to original PR there are 2 changes:
--return-failure-traceis enabled by default--return-failure-traceis added for any transaction. Not justcleos push transactionbut things likecleos add contract, etc. Essentially everything that results in pushing transaction.Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Nodeos now responds to a new RPC API
/v2/chain/send_transaction. This API requires two arguments: a boolean indicating whether or not to return failure traces, defaulting to true, and a signed transaction. Because this is a breaking change,/v1/chain/send_transactionhas been preserved and still accepts solely a signed transaction.Documentation Additions
Cleos support for the
push transactioncommand now defaults to using the new/v2/chain/send_transactionRPC API. It previously accepted an option--use-old-rpcto switch to/v1/chain/push_transaction. That option has now been supplemented with the option--use-old-send-rpcto switch to/v1/chain/send_transaction. Those two options are mutually exclusive. Neither--read-onlynor--return-failure-tracecan be used with either--use-old-rpcor--use-old-send-rpc.