Big ship deltas - 2.0 - Githubissues

EOSIO / eos

An open source smart contract platform

https://developers.eos.io/manuals/eos

MIT License

11.28k stars 3.6k forks source link

Big ship deltas - 2.0 #11051

Closed heifner closed 2 years ago

heifner commented 2 years ago

Change Description

https://github.com/eosnetworkfoundation/mandel/pull/24

Fix for deltas bigger than uint32_t size can indicate. This was hit on Wax.

Change Type

Select ONE:

[ ] Documentation
[x] Stability bug fix
[ ] Other
[ ] Other - special case

Testing Changes

Select ANY that apply:

[ ] New Tests
[ ] Existing Tests
[ ] Test Framework
[ ] CI System
[ ] Other

Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

tbfleming commented 2 years ago

On Mandel, I'm leaning against bumping the version. As long as the size isn't exceeded, it's backwards compatible. If it is exceeded, boost will try to decompress an empty stream. If boost throws, it will disconnect the client. If boost returns an empty stream, the client will receive an empty stream and fail to deserialize, indicating a problem.