EOSIO / eos

An open source smart contract platform
https://developers.eos.io/manuals/eos
MIT License
11.28k stars 3.6k forks source link

Are not you testing backwards compatibility? why can't checking secure coding guide? #4157

Closed testcode77 closed 6 years ago

testcode77 commented 6 years ago

As a result of the code review, there are very few code changes in 1.03 and 1.04. The compatibility of the minor version update does not seem to be tested and seems to be a problem.

We also frequently use vulnerable functions such as memcpy (). Secure coding guide is not applied.

Is this the main net?

ghost commented 6 years ago

@testcode77 Huge, experimental testnet I think 😂

testcode77 commented 6 years ago

EOS uses improper functions such as memcpy(). Low level C type function code that can buffer overflow. Most data types are 'AUTO'. auto type is very slow and Debugging is difficult. It is interesting.

tbfleming commented 6 years ago

If you find a case where memcpy overruns memory in eosio, then report it.