EOSIO / eosio-swift-vault

Utility library for managing keys and signing with Apple's Keychain and Secure Enclave
https://eosio.github.io/eosio-swift-vault/
MIT License
12 stars 8 forks source link

evaluatePolicy calls have localizedReason parameter hard coded as English string #57

Closed benjmartellopi closed 4 years ago

benjmartellopi commented 4 years ago

private func signWithBioCheck calls evaluatePolicy(.deviceOwnerAuthenticationWithBiometrics, localizedReason: "Sign Transaction", reply: { (isValid, error) ...

The localizedReason parameter is used in a system alert and with it being a hard coded English string here the app incorporating this SDK cannot change what is displayed.

This needs to be made something the implementing app can set appropriately so it can actually be localized for the country / language needed and to be adjusted as needed for application purposes.

opi-smccoole commented 4 years ago

Fixed in version 0.3.0