EOSIO / eosio.contracts

Smart contracts that provide some of the basic functions of the EOSIO blockchain
https://eosio.github.io/eosio.contracts/latest
MIT License
325 stars 574 forks source link

build.sh: switch from CMAKE_FRAMEWORK_PATH to CMAKE_MODULE_PATH #503

Open pnx opened 4 years ago

pnx commented 4 years ago

Change Description

CMAKE_FRAMEWORK_PATH is bad as it's read by cmake but it is not available in cmake scripts. Also according to the documentation this variable should contain path to OS X frameworks.

CMAKE_MODULE_PATH is the right way to go.

By adding this code to CMakeLists.txt (line 78 in this case):

message(FATAL_ERROR "${CMAKE_FRAMEWORK_PATH}")

And run:

$ export CMAKE_FRAMEWORK_PATH=/usr/opt/eosio.cdt/1.7
$ cmake ..

You get the following output:

-- The C compiler identification is GNU 7.5.0
-- The CXX compiler identification is GNU 7.5.0
...
-- Building eosio.contracts v1.9.0-rc1
-- Using eosio.cdt version 1.7.0
CMake Error at CMakeLists.txt:78 (message):

-- Configuring incomplete, errors occurred!

Deployment Changes

API Changes

Documentation Additions

pnx commented 4 years ago

Can you please use CMAKE_PREFIX_PATH instead and resubmit? Thank you

Fixed and pushed.