EOSIO / eosio.contracts

Smart contracts that provide some of the basic functions of the EOSIO blockchain
https://eosio.github.io/eosio.contracts/latest
MIT License
326 stars 500 forks source link

[docs] Suggestion / Change Request - Fix Description for 2nd Argument of setabi() #578

Open b1aafulei opened 2 years ago

b1aafulei commented 2 years ago

Code: Source

Regarding https://developers.eos.io/manuals/eosio.contracts/latest/action-reference/eosio.bios/index/#setabi

For the 2rd argument abi of the function void setabi(account, abi) the current description

"the abi hash represented as a vector of characters"

is inaccurate. It should simply be

"the ABI represented as a vector of characters"

The abi argument that gets passed is just a text string, not a hash. Hashing happens afterwards.

For source code, see

https://github.com/EOSIO/eosio.contracts/blob/d7bc0a5cc8c0c2edd4dc61b0126517d0cb46fd94/contracts/eosio.bios/src/eosio.bios.cpp#L5

and

https://github.com/EOSIO/eosio.contracts/blob/d7bc0a5cc8c0c2edd4dc61b0126517d0cb46fd94/contracts/eosio.system/src/eosio.system.cpp#L361