Error message in producer_pay is incorrect

[netuoso]

Description

After setting up an EOSIO testnet (deploying the eosio.system and eosio.token contract, issuing tokens, and voting) the user can run into issues getting the chain initialized due to initial supply and an incorrect error message.

Issue

eosio.system contract expects 150M tokens to be staked before the chain is considered active. However, the error message says only 15% of the total supply need to be staked.

Steps to Reproduce

• Initialize a fresh EOSIO testnet with producer1 configured as a producer
• Deploy necessary eosio.system and eosio.token contracts
• Issue 100M tokens to eosio from eosio.token
• Stake 100M tokens to eosio
• Vote for producer1
• Attempt to claimrewards as producer1
  • cleos system claimrewards producer1
• Observe the error message

What Happens

• Error message reads:
  • cannot claim rewards until the chain is activated (at least 15% of all tokens participate in voting)

What Should Happen

• Error message reads:
  • cannot claim rewards until the chain is activated (at least 150M tokens participate in voting)

Severity

Low severity here, but it will help users setting up a testnet to have more accurate error messages. An alternative fix would be for the eosio.system contact to detect the primary token liquid supply versus staked supply and set the min_activated_stake to a related value.

[deckb]

Moving this to the new reference system contract repo. Will evaluate here if it is still an issue.