search

EOSIO / eosjs-ecc

Elliptic curve cryptography functions: Private Key, Public Key, Signature, AES, Encryption, Decryption
288 stars 119 forks source link

Support for variable public_key prefixes (e.g EOS, TLOS, etc) #30

Closed barchef closed 6 years ago

barchef commented 6 years ago

Please consider adopting this PR to further expand the reach of EOSIO. It supports variable public key prefixes for EOSIO-based chains, while maintaining the default prefix of 'EOS' for backwards compatibility with any existing references.

barchef commented 6 years ago

I understand the move to the new key format but would argue that there will always be a need for the legacy format and, as a result, having a dynamic prefix should still be supported.

barchef commented 6 years ago

The Scatter team made some minor changes in a new branch to allow support for EOSIO forks, which will pass through a prefix to eosjs-ecc. See changes here: https://github.com/GetScatter/ScatterDesktop/pull/19

We hope you don't find an issue with approving this proposed change to make the hardcoded EOS prefix configurable.

jcalfee commented 6 years ago

Looks good .. Hope you don't mind if it remove "TELOS addition: " .. Git already tracks the contributer in the history.

barchef commented 6 years ago

Sounds good - thank you very much. Change whatever you see fit!

barchef commented 6 years ago

@jcalfee can you let me know once this is pushed to npm please? thx in advance

jcalfee commented 6 years ago

ok .. I'll publish soon.

jcalfee commented 6 years ago

Released in eosjs@16.0.2 and eosjs-ecc@4.0.3

barchef commented 6 years ago

Thanks @jcalfee!