use ripemd160 for electron 4.0.

EOSIO / eosjs-ecc

Elliptic curve cryptography functions: Private Key, Public Key, Signature, AES, Encryption, Decryption

288 stars 119 forks source link

use ripemd160 for electron 4.0. #45

Closed twksos closed 5 years ago

twksos commented 5 years ago

Electron 4.0 uses BoringSSL for crypto module. BoringSSL does not have the alias rmd160 -> ripemd160. ripemd160 works in normal OpenSSL node and Electron 4.0. This minor change should not break any existing function.

max-mapper commented 5 years ago

We also can't upgrade our app to Electron v4 or v5 without this PR

nsjames commented 5 years ago

https://github.com/EOSIO/eosjs-ecc/pull/56 this PR should add backwards compatible support. Removing rmd160 does apparently break some things.

c0d3ster commented 5 years ago

closing in favor of #56