search

EOSIO / eosjs

General purpose library for the EOSIO blockchain.
http://eosio.github.io/eosjs
MIT License
1.43k stars 463 forks source link

Replace net_usage_words with max_net_usage_words #117

Closed yepp4you closed 6 years ago

yepp4you commented 6 years ago

https://github.com/EOSIO/eosjs/blob/0159ba444d869614f0c66f1709f4dc3c504e8a5e/src/schema/chain_types.json#L52

jcalfee commented 6 years ago

This was changed at some point. Review the version table in the README to make sure your using eosjs with the correct version of nodeos..

jcalfee commented 6 years ago

There are still references to both in the back end code. The thing that matters is the transaction header serialization definition:

//transaction.hpp
EOSLIB_SERIALIZE( transaction_header, (expiration)(ref_block_num)(ref_block_prefix)(net_usage_words)(max_cpu_usage_ms)(delay_sec) )
yepp4you commented 6 years ago

It did so at eojs-api@6.0.1, it seems to be no problem because it is the net_usage_words from the latest version eosjs-api@6.0.2. Thank you.

https://github.com/EOSIO/eosjs-api/blob/57f13f139af3454fb3306c969d9416cebb6c2a66/src/exported-helpers.js#L57