search

EOSIO / eosjs2

Library to talk to the eos api
MIT License
29 stars 21 forks source link

Fixed some things that broke after merging #51

Closed esheffield closed 6 years ago

esheffield commented 6 years ago

Hit some problems after merging so fixing. The strangest thing was a problem with the export in ripemd.js. It wasn't being processed correctly but renaming to .ts fixed it. Hopefully this won't cause any other problems.

tbfleming commented 6 years ago

ts should error out from implicit any when building that.

esheffield commented 6 years ago

Worked with Jeff for a bit but haven't found a solution yet. Latest commit simply gets to a point where the build is working, but there is still a problem where Jest fails when attempting to transform the ripemd.js file. For some reason it doesn't like the export syntax.

It may still be worth getting this merged as it does correct some of the expected values for the tests and fixes an issue with the build. Talking with Jeff, he's hopeful his CI/CD work may fix the remaining problems.

esheffield commented 6 years ago

All fixed in latest commit - both tests and build are working now. Thanks to Leo!

randytorres commented 6 years ago

really weird those errors came out of nowhere once we added tests. Good job getting it fixed!