search

EOSIO / eosjs2

Library to talk to the eos api
MIT License
29 stars 21 forks source link

Reduce number of build configs and fix build errors #57

Closed jeffreyssmith2nd closed 6 years ago

tbfleming commented 6 years ago

Is ripemd.es5.js an accidental add?

jeffreyssmith2nd commented 6 years ago

No, it was something I wanted to add to discuss. With the tsconfig I have here, we don't need babel except for ripemd. If its not something we expect to change, then we can commit the compiled version like I did in this PR and get rid of babel.

If we don't want to go that route, then I'll add babel back to the build process and remove that file.

tbfleming commented 6 years ago

I'm ok with this. Move it to src/ even though it's not really source so it's not at top level.

brandonfancher commented 6 years ago

That's awesome, @jeffreyssmith2nd. I agree that it absolutely makes sense to commit the compiled version of this one file in order to avoid the complexity of babel transpilation. 💥

jeffreyssmith2nd commented 6 years ago

Dependent on #58 for the build/tests to succeed