Producer urls on index page are now clickable

EOSPortal / eosportal-front

🗳EOSPortal Community Voting

https://eosportal.io

28 stars 22 forks source link

Producer urls on index page are now clickable #50

Closed Soleone closed 6 years ago

Soleone commented 6 years ago

for convenience, if the url is displayed anyways it might as well be clickable
home page opens in a new tab (same behaviour as on the producer show page)

Question: Do URLs need to be sanitized first? It seemed like they might already be sanitized somewhere, but not quite sure.

Before:

After:

kesar commented 6 years ago

Sorry @Soleone I missed this PR. The reason because we didnt allow links, its that there may be malicious urls to scam website, so for purpose of security we avoid it.

pnx commented 6 years ago

Closing as @kesar explains why this wont be merged.