search

EOX-A / EOxElements

A Web Component collection of geospatial UI elements, crafted by EOX.
https://eox-a.github.io/EOxElements/
MIT License
13 stars 2 forks source link

Infinite Loops in Storybook #1227

Open spectrachrome opened 2 months ago

spectrachrome commented 2 months ago

I have recently been doing intense profiling of the slider ticks generation and found it to be impossible to do properly inside Storybook because of an infinite loop that stems most likely from an issue with Storybook itself.

As a test case, one can take a large dataset of date strings (~20,000 entries), loaded as JSON into a Storybook arg populating the slider steps of the Time Control. With this many entries, the Storybook page will freeze and crash entire tabs.

Now press the button which opens the iframe with only the element itself, and you will see: the initialization of the slider takes just 90ms instead of 10 seconds.

I would like to start a discussion on the topic since I am not sure what to make of the version fixes mentioned in the issue thread.

silvester-pari commented 1 month ago

@spectrachrome did removing the @storybook/addon-interactions plugin as mentioned in that issue help? I don't think anyone uses that interactions functionality.