Variable misnamed in core.py

EPAENERGYSTAR / epathermostat

Methods for measuring and reporting connected thermostat savings

17 stars 9 forks source link

Variable misnamed in core.py #18

Closed lirainer closed 4 years ago

lirainer commented 4 years ago

The RESISTANCE_HEAT_USE_BIN_TUPLE_FIRST variable is assigned at line 38 of core.py but referenced at line 1595 as RESISTANCE_HEAT_USE_BIN_FIRST_TUPLE.

I assume this has not shown up as an error since rhu_first has never been None.

Solution

rename to RESISTANCE_HEAT_USE_BIN_FIRST_TUPLE

craigmaloney commented 4 years ago

This has been fixed in 1.7.1 and been removed in 2.0. Thanks!