search

EPCCed / wee_archie

BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Remove camera defaults in AbstractUI.py #1

Closed tsubic closed 8 years ago

tsubic commented 8 years ago

There are some vtkCamera settings in ~/framework/client/AbstractUI.py that will not be suitable for all the demos. I suggest to completely remove lines 50-53 and add vtkCamera settings to each demo separately in the RenderFrame method. This could be done like the mapper and actor were done:

try: win.camera except: win.camera = win.vtkwidget.GetRenderWindow().GetRenderers().GetFirstRenderer().GetActiveCamera() win.camera.SetFocalPoint(0.,0.,0.) win.camera.SetPosition(50.,0.,0.) win.camera.Roll(-90)

mesham commented 8 years ago

@gpsgibb , are you happy with this? Is it OK to make this change?

gpsgibb commented 8 years ago

Yes. I will make the changes later on today

On 1 Aug 2016, at 08:49, Nick Brown notifications@github.com wrote:

@gpsgibb https://github.com/gpsgibb , are you happy with this? Is it OK to make this change?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EPCCed/wee_archie/issues/1#issuecomment-236512074, or mute the thread https://github.com/notifications/unsubscribe-auth/AQZuDWkWkJErXBljWsLwwC_k4YjiUfc2ks5qbaUdgaJpZM4JWQ8t.

The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336.

gpsgibb commented 8 years ago

Changes have been made (a little later than promised) - see commit bfe5358. A demo's developer now needs to set up their own camera defaults (or use whatever VTK's ones are). I also separated all the vtk stuff out from the AbstractUI, so now to use vtk things, derive your demo's UI from AbstractvtkUI. Other than that, there should be no differences.