EPFL-LAP / dynamatic

DHLS (Dynamic High-Level Synthesis) compiler based on MLIR
Other
63 stars 19 forks source link

[MLIR] [LLVM] ninja check-dynamatic failed #164

Open PigBrainOverflow opened 1 month ago

PigBrainOverflow commented 1 month ago

[0/1] Running the Dynamatic regression tests FAIL: Dynamatic :: Dialect/Handshake/invalid.mlir (26 of 26) **** TEST 'Dynamatic :: Dialect/Handshake/invalid.mlir' FAILED **** Exit Code: 139

Command Output (stderr):

RUN: at line 1: ~/envs/dynamatic/build/bin/dynamatic-opt ~/envs/dynamatic/test/Dialect/Handshake/invalid.mlir --split-input-file --verify-diagnostics

--



Failed Tests (1): Dynamatic :: Dialect/Handshake/invalid.mlir

Testing Time: 0.13s Passed: 25 Failed: 1 FAILED: test/CMakeFiles/check-dynamatic ~/envs/dynamatic/build/test/CMakeFiles/check-dynamatic cd ~/envs/dynamatic/build/test && /usr/bin/python3.10 ~/envs/dynamatic/polygeist/llvm-project/build/./bin/llvm-lit -sv ~/envs/dynamatic/build/test ninja: build stopped: subcommand failed.

Jiahui17 commented 1 week ago

Hi @PigBrainOverflow thank you for reporting this issue!

I played with different settings and I discovered that:

  1. The "expect-error" thing only works if we build dynamatic in Debug mode.
  2. If we remove the "expect-error" comment line, dynamatic-opt will not throw a seg fault but a normal error message.

So the test would not fail if we build dynamatic in Debug mode. Maybe we can put this caveat in the GettingStarted guide.

I will close this issue for now; feel free to reopen it if the issue persists after building the project in the Debug mode.

ebosnjak commented 1 week ago

As @paolo-ienne suggested, I am reopening this, since this behavior should be considered a bug, for someone to fix at some point.