Closed asleix closed 6 months ago
As Lucas suggested, smaller and more meaningful tests proved more useful for verification. The new tests are included and the old ones were removed.
Hi @RamirezLucas! Emmet and I met this afternoon to discuss his comments and we agreed that the PR is now ready to be merged. Thanks a lot!
This commit updates the way that
SpecCommitOp
andSpecSaveCommitOp
are connected toSpeculatorOp
. The commit and commit-like control signals should replicate the actual path that speculative tokens take, and only reach the operations when speculative tokens do.The changes include:
routeBranchControlTraversal
,prepareAndPlaceCommits
,prepareAndPlaceSaveCommits
.inheritBB
such that the newly created operations have a BB assigned.ninja check-dynamatic-experimental
from yourbuild
.