Loan Requests: implement requests

EPFLSWENT2024G1 / partagix

A code repository designed to show the best GitHub has to offer.

3 stars 0 forks source link

Loan Requests: implement requests #140

Open Patrick-Pataky opened 2 months ago

Patrick-Pataky commented 2 months ago

Currently, clicking on an item when being on the Loan Screen redirects you to an editable item. This is wrong.

Your task:

Clicking on an item should redirect you to a new screen, similar to View/Create/Edit Item, but with new options:
- set loan's start+end date. Please include a calendar, similar to the one on the bootcamp. If you struggle with this task, ask @Valentin889 or @LozanoCyrielle
- the item shouldn't be editable
- it should include a "Submit" button, to submit the request

Valentin889 commented 2 months ago

Wouldn't it be better if we could group items into one request ? At least when it's for the same user it seems way better (more work though) maybe I can start with what you propose and in the future we upgrade it ?

AntoineBut commented 2 months ago

Wouldn't it be better if we could group items into one request ? At least when it's for the same user it seems way better (more work though) maybe I can start with what you propose and in the future we upgrade it ?

That is in my opinion a very necessary improvement that should indeed be in the first official release.

In the meantime, can you link the PR that implemented this and close the issue ?

Patrick-Pataky commented 2 months ago

Wouldn't it be better if we could group items into one request ? At least when it's for the same user it seems way better (more work though) maybe I can start with what you propose and in the future we upgrade it ?

That's a great idea ! We will discuss it during the next meeting we have. This task remains at a very low priority for the milestone 2.