Maintenance Updates (Jul-2020)

[nelsonni]

The following items need to be updated:

1. Update the Alumni section of the People page to include the current role/employer, and year of graduation, for each of the former students (similar to information included on https://web.engr.oregonstate.edu/~sarmaa/students/). For example:

     Shane McKee
     MS, Oregon State University (2016)
     Software Engineer, Intel

2. Update the Current Graduate Students section of the People page to include current status:

• Caius Brindescu has graduated and should be moved to the Alumni section, and his current role should be listed as Technical Staff, Etleap.
• Marjan Adeli has graduated and should be moved to the Alumni section, but no current role should be shown.
• Manideepa Saginatham has graduated and should be moved to the Alumni section, but no current role should be shown.
• Jillian Emard should be moved to the Alumni section, and her current status should be verified with Anita.
• Umme Ayda Mannan should be added and her status should be listed as PhD Candidate, Oregon State University. Her GitHub username is unknown, so please verify both her GitHub username and which URL should be linked to her listing on the website (i.e. all current students have links to their own websites, their GitHub profile page, or a LinkedIn profile).
• Turgay Caglar should be added and his current role should be listed as MS Student, Oregon State University. His GitHub username is @cglrtrgy, but he does not have a GitHub profile picture which can be pulled in (so the EPICLab logo should be used instead).

3. Update the Current Undergraduate Students section of the People page to include current status:

• Evie May should be moved to the Alumni section, and her current status should be verified with Anita.
• Catherine Stevens should be added to the Current Undergraduate Students section, and her status should be listed as Undergraduate Researcher, Oregon State University. Her profile picture should be pulled from her GitHub profile, however, she is not currently added as a member of the EPICLab GitHub organization and her username is unknown.

3. Add all of the previous lab members, as listed on https://web.engr.oregonstate.edu/~sarmaa/students/, to the Alumni section. Order them according to their graduation year (i.e. 2020 graduates at the top and the rest in descending order).

[audreyau]

For the Alumni section, do you want the students in the same order as Anita's website (Graduate Students from most recent to least recent and then Undergraduate Students from most recent to least recent), or do you want them all in order of year graduated (from most recent to least recent)?

[nelsonni]

All of them should be in chronological order based on graduation year. Anita's website has them grouped by graduate and undergraduate students, but that is unnecessary for the EPICLab website. So for example, the first few alumni would be:

Caius Brindescu
PhD, Oregon State University (2020)
Technical Staff, Etleap

Manideepa Saginatham
MS, Oregon State University (2020)

Leif Tsang
BE, Oregon State University (2020)
Recent Graduate Program, Naval Undersea Warfare Center (NUWC)

[audreyau]

I got Ayda's GitHub username, but she doesn't have a profile picture. Should I user her LinkedIn profile picture instead?

[audreyau]

Also, since Turgay does not have a profile picture, should I use his GitHub username as the custom link?

[nelsonni]

No. Per item 3 in #6, we are using the following code to dynamically pull GitHub profile photos for each current student:

<img src="https://github.com/nelsonni.png" class="profileimg">

This allows students to quickly and easily change their own pictures on the EPICLab website (through changing their GitHub profile photo). If a student doesn't set a profile photo, we respect the desire for privacy and opt for the EPICLab logo instead via the alternative code:

<img src="https://github.com/EPICLab.png" class="profileimg">

[audreyau]

Should I also remove Jett Seale from Current Undergraduate Students since he is under "Alumni"?

[nelsonni]

Jett is still a current undergraduate student working with us. I just checked both the current https://epiclab.github.io/people.html and https://web.engr.oregonstate.edu/~sarmaa/students/ sites, and neither shows him as alumni. Is there a third location in which you're seeing him listed as alumni?

[audreyau]

Yes, on Anita's website, which is probably my bad. I'll update hers afterwards too haha! Also, I messaged Turgay, and he wants to use his LinkedIn profile picture. Also, since I'm collecting all of these GitHub usernames, what should I do with them?

[nelsonni]

Okay, then in order to use Turgay's LinkedIn profile picture, use the following code (instead of the code referenced above):

<img src="https://www.linkedin.com/in/turgay-caglar-6a2780a0/detail/photo/" class="profileimg">

For anyone that isn't a member of the EPICLab GitHub organization, I will need their GitHub username in order to invite them to join. So please send them to me.

[audreyau]

Is there a way we can change the code for those who opt for an EpicLab profile picture? It seems that it adjusts the dimension of this picture according to how long the text is (since Catherine has a long title, it stretched out the photo a lot). This also causes slight problems because the photos aren't aligned properly (the red lines in this screenshot shows this).

also, Ayda's GitHub username is @aydamannan

[nelsonni]

I'm not 100% certain about the cause, but there are a few things going on that might need to be investigated. The person profiles are setup to use CSS Flexbox so that they flow onto new rows when the available window width is resized (i.e. if only 4 profile images will fit on a row, all other profile images move to the second row, and the remaining profile images then try to fit onto the second row until full, and so on). Most of this is setup and controlled through CSS, which would be in the full-width-pics.css file.

As for profile images maintaining their aspect ratios, there was a previous issue #8 that described a similar problem. The fix for that was to set the following .profileimg CSS class:

.profileimg{
  max-width:100%;
  height:262px;
  margin-right:20px;

This was a partial adaptation from the discussions in this StackOverflow post: https://stackoverflow.com/questions/12991351/css-force-image-resize-and-keep-aspect-ratio.

My initial thoughts are that we either need to:

1. Update the max-width to be a specific px value instead of 100%, or
2. Set .name-box to have text wrap when it reaches the boundaries of it's parent div element (via the overflow-wrap property).

[audreyau]

That worked perfectly! I changed max-width to 262px and margin-right to 50px (really any number worked here as long as it was 30px or more), and everything aligned properly! I've finished all the issues, but I will make the pull request tomorrow since I'm still waiting for Catherine to give me her GitHub username.