Open tomekskuta opened 11 months ago
Hey @tomekskuta, thank you so much for your contribution! 🚀
🔄 We're currently running a few checks to make sure that everything is great with your contribution. If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.
Results are coming soon, stay tuned!
For some reason, my dimmers fire move_MoveMode.Down_83_0_0
event for the button_down_long
, without the bitmap parts... Other events look consistent with your changes.
Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! :tada: Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.
Sections marked as * are required and need to be filled in.
Proposed change*
I changed mapped action names for long press and for releasing long press. I did it because these actions with current blueprint didn't work because of wrong action names. Made the change only for ZHA. New actions maps:
button_up_long
:move_with_on_off_MoveMode.Up_83
button_up_release
:stop_with_on_off
button_down_long
:move_MoveMode.Down_83_bitmap8.0_bitmap8.0
button_down_release
:stop_with_on_off
The solution tested with 3 Ikea e1743 dimmers.
Checklist*
npm run format
before submitting my Pull Request.