EPMatt / awesome-ha-blueprints

A curated collection of automation blueprints for Home Assistant.
https://epmatt.github.io/awesome-ha-blueprints
GNU General Public License v3.0
834 stars 250 forks source link

[Resolve #576] Philips Hue Dimmer v2 - Edit trigger_delta; make whitespacing optional. #577

Open TTvanWillegen opened 10 months ago

TTvanWillegen commented 10 months ago

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! :tada: Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Proposed change*

Instead of obligatory whitespacing between the key-semicolon and value, make these optional. Same for whitespace between the two last_action parts.

Resolves #576. Instead of action taken as stated in issue (remove whitespace from regex), uses optional whitespace (\s*?)

Checklist*

github-actions[bot] commented 10 months ago

Hey @TTvanWillegen, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution. If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

nomike commented 8 months ago

I have come up with exactly the same solution and found this PR when I was about to submit mine.

I have tested it on my setup, it is safe could be merged IMHO.