EPMatt / awesome-ha-blueprints

A curated collection of automation blueprints for Home Assistant.
https://epmatt.github.io/awesome-ha-blueprints
GNU General Public License v3.0
834 stars 250 forks source link

Fixed double press issue #593 #600

Open ZtormTheCat opened 8 months ago

ZtormTheCat commented 8 months ago

Now correctly sets trigger_delta and last_controller_event for double press events.

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! :tada: Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Proposed change*

Now correctly sets trigger_delta and last_controller_event for double press events and thus closes #593

Checklist*

github-actions[bot] commented 8 months ago

Hey @ZtormTheCat, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution. If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

p4sI commented 8 months ago

Probably it should also be corrected here https://github.com/EPMatt/awesome-ha-blueprints/blob/9ee5920a3633c87bd8ee8713b83bbbf4705cc31d/blueprints/controllers/ikea_e2001_e2002/ikea_e2001_e2002.yaml#L406 but I cannot verify because I don't have this controller.

pfiorentino commented 5 months ago

Probably it should also be corrected here

https://github.com/EPMatt/awesome-ha-blueprints/blob/9ee5920a3633c87bd8ee8713b83bbbf4705cc31d/blueprints/controllers/ikea_e2001_e2002/ikea_e2001_e2002.yaml#L406

but I cannot verify because I don't have this controller.

Yup! I do have an IKEA e2002 and I can confirm this is also required to make the double click work on the controller.

[Edit]: As far as I can see it has already been created here :) → https://github.com/EPMatt/awesome-ha-blueprints/pull/546/files

nljuba-eng commented 4 months ago

None of the controllers has a working double click event! Is this pull request merged already?