Open paulvanbrenk opened 1 year ago
Hi @paulvanbrenk, thank you so much for reporting here.
This behavior is quite strange. Since we pass Prettier flags when the action is configured with github-pr-review
as well, the filtering applied to prettier should have the same effect as with github-check
.
This is the code for the github-pr-review
reporter:
What happens if you run prettier locally with the same flags? eg. by executing the command from the package root directory: $(npm root)"/.bin/prettier --write **/*.{js,ts,tsx,md,json}
?
Thanks!
What happens if you run prettier locally with the same flags? eg. by executing the command from the package root directory: $(npm root)"/.bin/prettier --write */.{js,ts,tsx,md,json} ?
That works as expected.
It also looks like prettier is invoked twice when run with the github-pr-review
reporter
+1
This is how I configured the action in my workflow file
However in the log from the github action I see the following:
And I get suggestions for changes in the yarn.lock file.
Any ideas?
edit: created a repo to show the issue. You can see the errors reported in the logs for the workflow for this PR
https://github.com/paulvanbrenk/prettier-action/pull/1