EPOC-NZ / JADE.jl

Other
9 stars 2 forks source link

WIP: start refactoring the data file parsing to use CSV.jl #30

Closed odow closed 1 year ago

odow commented 1 year ago

I started looking at #16, but man, there are some complications. I don't know if there is a single ground truth for what the files expect.

There are optional columns, additional columns, non-tabular things like this:

image

Perhaps before I keep going with this we should work on the tests.

codecov-commenter commented 1 year ago

Codecov Report

Merging #30 (9799e97) into develop (08d21e6) will decrease coverage by 0.02%. The diff coverage is 92.30%.

@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
- Coverage    62.20%   62.17%   -0.03%     
===========================================
  Files           19       19              
  Lines         2212     2205       -7     
===========================================
- Hits          1376     1371       -5     
+ Misses         836      834       -2     
Impacted Files Coverage Δ
src/JADE.jl 60.00% <ø> (ø)
src/data/thermal.jl 95.34% <85.71%> (+2.01%) :arrow_up:
src/data/hydro.jl 78.87% <100.00%> (-0.03%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

odow commented 1 year ago

Closing in favor of #34