Open adow031 opened 1 year ago
Hmm. The test failures with simulation_stopping
are likely my fault. I changed the default termination in SDDP.jl, but if you set an iteration limit it should respect that... let me take a look
See https://github.com/odow/SDDP.jl/pull/662. I added it in the wrong place
Should be fixed by https://github.com/JuliaRegistries/General/pull/91019
Merging #44 (53acbb9) into main (8a6cfe2) will not change coverage. The diff coverage is
50.00%
.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@ Coverage Diff @@
## main #44 +/- ##
=======================================
Coverage 71.35% 71.35%
=======================================
Files 18 18
Lines 2126 2126
=======================================
Hits 1517 1517
Misses 609 609
Files Changed | Coverage Δ | |
---|---|---|
src/data/demand.jl | 70.08% <0.00%> (ø) |
|
src/model.jl | 76.76% <ø> (ø) |
|
src/simulate.jl | 97.15% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
:loudspeaker: Have feedback on the report? Share it here.
cc @adow031 happy with this?
Fixes in a couple of places when using the scale_reservoirs option.