EPRV3EvidenceChallenge / Inputs

Input Data & Model for the EPRV3 Evidence Challenge - Start Here
MIT License
11 stars 10 forks source link

Eccentricity prior #14

Closed j-faria closed 6 years ago

j-faria commented 6 years ago

I think there are a couple of typos in the eccentricity prior in model.pdf. As is, it's not defined for e=0. Also, "0 for e>=0" should read "0 for e >=1"

eford commented 6 years ago

Hi Joao,

Thanks for pointing that out. You're definitely right that it should read "0 for e >=1". But if I fix that, then I don't understand you comment about it not being defined for e = 0. p(e) does go to zero at e=0, but that's different than undefined. Or am I missing your point?

Thanks, Eric

On Wed, Sep 13, 2017 at 3:27 PM, João Faria notifications@github.com wrote:

I think there are a couple of typos in the eccentricity prior in model.pdf https://github.com/EPRV3EvidenceChallenge/Inputs/blob/master/model/model.pdf . As is, it's not defined for e=0. Also, "0 for e>=0" should read "0 for e >=1"

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/EPRV3EvidenceChallenge/Inputs/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQywizFIQnERPBREDpmm4K9w9FF2UrYks5siCy6gaJpZM4PWmzg .

-- Eric Ford Professor of Astronomy & Astrophysics Center for Exoplanets & Habitable Worlds Center for Astrostatistics Institute for CyberScience Penn State Astrobiology Research Center Pennsylvania State University

j-faria commented 6 years ago

Hey Eric, From what I understand, in order to truncate the distribution, you divide by the cdf (evaluated at e=1). But as is written, the denominator is 0 for e=0.

benelson commented 6 years ago

Hey Joao. That "e" in the cdf might be a typo. I'm pretty sure it should be e_max = 1, as you pointed out.

eford commented 6 years ago

Oh, I see... Ben's right, of course... the normalizing constant is evaluated at e_max =1. I've updated the model.tex and model.pdf. Does that make everything more clear?

j-faria commented 6 years ago

Sorry, I could've been a bit more clear in what was wrong. That was it, closing the issue.