search

EPSCoR / ERCore

ERcore content management system to assist with NSF EPSCoR reporting
4 stars 7 forks source link

External Collaborator Institution Field filter #43

Open tschet opened 8 years ago

tschet commented 8 years ago

The Institution field on the Collaborator content type (field_er_collab_ref) by default uses the "er_participating_institutions" filtering view. This means that you can only select Participating Institutions when adding external collaborators. Awkward. I believe the correct view to use would be "er_collaborating_institutions".

tschet commented 8 years ago

The "Link to node" setting should also be deactivated in that reference view.

aturling commented 8 years ago

I didn’t even notice that there was a separate view for collaborating institutions. The “participating institutions” view seems to be misnamed because it pulls all of the institutions in the system. This view also appears in the institution tab on user accounts.

I actually prefer the style of the current “er_participating_institutions” for collaborations, with the home vs. globe icons and the participating institutions bolded.

Should there be two separate views for participating vs. collaborating institutions in the next release of ERCore, or could there just be one “all institutions” entity reference view? For us, at least, almost all of our users are from the participating institutions, but a couple (e.g., evaluators) are from outside organizations, so it’s easiest to just list all of the institutions in the system on the institution tab when they set up their accounts.

tschet commented 8 years ago

The out of the box "er_participating_institutions" does style the participating institutions, but filters out the non-participating institutions. It also changes the appearance by the use of non-semantic code. It uses an empty tag with a class for the sole purpose of displaying the Home icon, and then wraps the university with a strong tag. Why not just use a class on a div wrapper for both? If you used the Participating field value to drive the class, you could style them both differently fairly easily. It would also be easy to change if you wanted to style it differently. Since using code contrary to specification triggers accessibility errors on a number of testing tools, I'd hope we'd avoid doing that.

iserna commented 8 years ago

Propose to meet with Admin and Tech team to work through Collaborations Content Type. Also, review Douglas updated version.