EPSCoR / ERCore

ERcore content management system to assist with NSF EPSCoR reporting
4 stars 7 forks source link

External collaborator node title can be too long #67

Closed aturling closed 7 years ago

aturling commented 7 years ago

I just ran into this issue on our site: because the external collaborator node title is stored in the format "[name] from [department] @ [institution] on [collaboration name]" and one external collaborator had the combination of 1) a long name, 2) a long department name, and 3) the collaboration itself had a long title (163 chars), the overall title for the external collaborator node was too long to be stored in the database.

I reduced the character limit for collaboration titles which is probably enough to prevent this from happening again. Another option is to truncate this string to the character limit in includes/node_logic.inc (https://github.com/EPSCoR/ERCore/blob/7.x-3.2/includes/node_logic.inc#L285):

$node->title = "$name from $inst_with_dept on {$collab->title}";

Has anyone else experienced this?

ercore commented 7 years ago

@aturling we have not experienced this in NM. I will ask if anyone else has during our meeting this afternoon. Thanks!

ercore commented 7 years ago

This has not been an issue for other jurisdictions but everyone agreed that this fix is relevant and will implement if and when needed.