EQAR / deqar_frontend

Version 2 of the DEQAR Admin Interface, with create-react-app v2, refreshed 3rd party libraries, and many more...
0 stars 0 forks source link

MyReport Menu should be elided with Dashboard View #12

Closed Gyukat closed 3 years ago

Gyukat commented 5 years ago

We think that there is no need for a separate Dashboard as it more or less replicates the MyReport functionality. So:

Colin and I realised that there is a problem when we define access to reports because sometimes agencies have reports submitted through proxies, but others submitted by themselves. This is fine; the agencies should only have edit access through MyReports to the ones they submit.

Related to this, we realise that Agencies may use CSV/API with their local ID to overwrite reports submitted already by proxies. We should discuss, but probably local IDs should be hooked in our system to BOTH a creator and a submitter...so they can be used only by the same combination in order to overwrite.

JoshBone commented 5 years ago

Colin and I realised that there is a problem when we define access to reports because sometimes agencies have reports submitted through proxies, but others submitted by themselves. This is fine; the agencies should only have edit access through MyReports to the ones they submit.

So does this mean, that reports which are about the agency should be displayed in the MyReports, but if they were submitted by a proxy it shouldn't be editable?

Gyukat commented 5 years ago

No, only those submitted by the institution should be viewed and editable. All others (even those by proxy) can be in the "reference data/reports". Related to this, an agency should only have edit rights over those that it actually uploaded.

Gyukat commented 5 years ago

I completely changed the policy on this! So, basically:

The MyReports list should reflect this, by showing proxy reports in BOTH places (for the owning and proxy agency) but only the owning agency can edit. Sorry for the confusion.