EQAR / deqar_frontend

Version 2 of the DEQAR Admin Interface, with create-react-app v2, refreshed 3rd party libraries, and many more...
0 stars 0 forks source link

Report list problems #28

Closed Gyukat closed 3 years ago

Gyukat commented 5 years ago

EKKA just tested our new manual report submission interface, and they didn't notice the possibility to edit records. We discussed and have a few possible suggestions.

These are just thoughts, SO if you have more elegant solutions, we are open to suggestions.

Gyukat commented 5 years ago

More thoughts on MY Report List:

Gyukat commented 5 years ago

More thoughts on Reports list:

Gyukat commented 5 years ago

In general, there is one layer of grey padding around everything that seems unneeded...any way to remove it? This would fill the space more nicely... DONE

Gyukat commented 5 years ago

MyReports: all the dates say "Invalid date"...don't know why. DONE

Reports: still says "Activity" instead of "Activity Type" in the column. DONE

Both: on the filters validity, I think "Active" should read "Current" DONE

Functionality: DEQAR ID doesn't sort. DONE

Basically, everything in the string above is still a problem.

JoshBone commented 5 years ago

You should include the Local IDs along with the DEQAR IDs in the following way "DEQAR ID / Local ID", also in the label and filter box. The sort can be by DEQAR ID, but the filter should allow you to enter the local ID as well. This would mean that the filter should allow parts of the string (perhaps with some criteria ala institution names).

This is the only one left.

JoshBone commented 5 years ago

You should include the Local IDs along with the DEQAR IDs in the following way "DEQAR ID / Local ID", also in the label and filter box. The sort can be by DEQAR ID, but the filter should allow you to enter the local ID as well. This would mean that the filter should allow parts of the string (perhaps with some criteria ala institution names).

Can you check on MyReports if it's suitable like this?

Gyukat commented 5 years ago
Gyukat commented 5 years ago

Interestingly, the filter works different for the Local Id and the DEQAR Id. For Local ID, you can put the beginnings of numbers and it finds them...for DEQAR Id, you need the whole number. I prefer the way you did it for Local Id. DONE

JoshBone commented 5 years ago

Validity: I think you still need the word "to " in between the two dates, even when you put "N.A."

Something like this?

Screenshot 2019-08-14 at 16 22 37
JoshBone commented 5 years ago

IDs: it looks like it is one number. In the very least you should not include the local ID in the link. This will separate it more clearly from the DEQAR ID. Maybe if you disappear the link and add parentheses to the local ID this will work. (In that case, you should also add parentheses to the label.) Do you have other ideas about how to better separate?

What about this?

Screenshot 2019-08-14 at 16 44 46
JoshBone commented 5 years ago

I've put them to admin test for checking...

Gyukat commented 5 years ago

Report List: activity type has been added to the list, but it is NOT populated!!!!

Validity: I think you still need the word "to " in between the two dates, even when you put "N.A."

Something like this?

Screenshot 2019-08-14 at 16 22 37

Yes, nice

Gyukat commented 5 years ago

Btw, the view+edit breadcrumb is good, but I still think the edit should return you to the view record after you submit. (From there you can go back to the list.)

So, basically, when you are editing a report records and you EITHER "close" or "submit", please return the user to the VIEW of the same record.

Gyukat commented 5 years ago

Still need to figure out how to get submitter and agency access to check a lot of this...

Gyukat commented 5 years ago

IDs: it looks like it is one number. In the very least you should not include the local ID in the link. This will separate it more clearly from the DEQAR ID. Maybe if you disappear the link and add parentheses to the local ID this will work. (In that case, you should also add parentheses to the label.) Do you have other ideas about how to better separate?

What about this?

Screenshot 2019-08-14 at 16 44 46

This seems fine! Can't check it live yet.