EQAR / deqar_frontend

Version 2 of the DEQAR Admin Interface, with create-react-app v2, refreshed 3rd party libraries, and many more...
0 stars 0 forks source link

Agencies: self-editing doesn't work #73

Closed ctueck closed 2 years ago

ctueck commented 3 years ago

Trying to edit the own agency's contact details leads to a 403 Forbidden response:

image

ctueck commented 3 years ago

Reopening this one, as there are still two issues remaining with self-editing

First, the names and acronyms (current as well as former) show as editable fields, but shouldn't be changeable by agencies themselves.

Then, only for agency website, contact person and address changes are saved. These fields show as editable (and they should be), but changes aren't saved:

ctueck commented 3 years ago

It seems that changes in the URL "Reports by the agency" are still not saved.

ctueck commented 3 years ago

Another small related issue: it would be good if the "Add Transliteration" links aren't shown when agencies self-edit, as they cannot change the name themselves.

image

JoshBone commented 3 years ago

It seems that changes in the URL "Reports by the agency" are still not saved.

I've tried in the sandbox and it updated the URL.

ctueck commented 3 years ago

I've tried in the sandbox and it updated the URL.

Logged in as you or as an agency user? Maybe it's because of a field missing in the serializer, I created an issue in the backend repo: https://github.com/EQAR/eqar_backend/issues/391

JoshBone commented 2 years ago

Solved by https://github.com/EQAR/eqar_backend/commit/94c5ea0e8913b71bd152a190ef88d771dc8dca19.