EQAR / eqar_backend

REST API backend for the DEQAR database.
GNU General Public License v3.0
1 stars 0 forks source link

Europass: report titles #429

Closed ctueck closed 2 years ago

ctueck commented 2 years ago

Suggest a small enhancement, as we now always tag the report title (from our file display name) as English:

https://github.com/EQAR/eqar_backend/blob/master/connectapi/europass/accrediation_xml_creator.py#L104

https://github.com/EQAR/eqar_backend/blob/master/connectapi/europass/accrediation_xml_creator.py#L181

Maybe it will usually be more accurate to tag it with the language of the report (or the first one to be precise, as we can only use one language here - in practice we probably have very little reports with multiple languages).

Secondly, when no file display name is set, maybe we could send a standard text ("quality assurance report") instead of an empty element?