search

EQAR / eqar_frontend

(archived - see new repository deqar_frontend) ReactJS admin frontend for the DEQAR database.
https://github.com/EQAR/deqar_frontend
0 stars 0 forks source link

New Report: Valid from / Valid to date label and validation errors #101

Closed Gyukat closed 6 years ago

Gyukat commented 6 years ago

The valid from and valid to are both functioning improperly: -first, the valid to IS NOT required...so it should not be validated as such and should not have an asterisk -second, the validation of both is not correct:
---valid from should be checked against the agency registration start and end dates. Valid from should not be before the registration start date nor after the registration end date. ---valid to, when provided, should be checked only against the valid from date to ensure that it is later than the valid from date.

ctueck commented 6 years ago

To illustrate, this is the validation currently happening but should not:

image

gygabor commented 6 years ago

fixed it, please check it on the test server.

Gyukat commented 6 years ago

Didn't Josh fix this earlier?

gygabor commented 6 years ago

Yes I fixed it but I didn't know that the solution was good. Josh just said it was OK. Sorry

Gyukat commented 6 years ago

:)