EQAditu / AdvancedCombatTracker

Advanced Combat Tracker
https://advancedcombattracker.com
118 stars 25 forks source link

The row data for the AttackType column doesn't seem to be appearing #93

Closed mastk0 closed 2 months ago

mastk0 commented 9 months ago

As shown in the screenshot, it seems that Japanese language support is not functioning properly, as the row data for the AttackType column is not being displayed. However, when performing a right-click to copy as CSV, it is evident that the Japanese action names are correctly included.

0001_edit
EncId,STime,RelativeTime,Attacker,SwingType,AttackType,DamageType,Victim,Damage,DamageString,Critical,CriticalStr,Special,StatusDuration,OverHeal,DirectHit
214a73ef,2024-01-17 13:08:31,2.008,YOU,8,ルインジャ実行可,,YOU,0,No Damage,F,None,None,60,0,
214a73ef,2024-01-17 13:08:32,3.39,YOU,2,ルインジャ,Magic,木人,33037,33_037,T,None,None,,0,True
214a73ef,2024-01-17 13:08:29,0,YOU,2,ルインガ,Magic,木人,11646,11_646,F,None,None,,0,
214a73ef,2024-01-17 13:08:31,2.676,YOU,2,ミアズマバースト,Magic,木人,13204,13_204,F,None,None,,0,
214a73ef,2024-01-17 13:08:31,2.008,YOU,2,エナジードレイン,Magic,木人,9515,9_515,F,None,None,,0,True
214a73ef,2024-01-17 13:08:31,2.676,YOU,8,エーテルフロー,,YOU,0,No Damage,F,None,None,9999,0,
214a73ef,2024-01-17 13:08:31,2.008,YOU,8,エーテルフロー,,YOU,0,No Damage,F,None,None,9999,0,
mastk0 commented 9 months ago

Similarly, the 'Victim' field was affected. While 'You' is visible, '木人' is not displayed, indicating a high possibility of a Japanese language-related issue.

EQAditu commented 9 months ago

Likely this is a font rendering problem in GDI+.

Could you export a *.act file and attach it here for me to test with?

Also, I need to know what font you're currently using. The least error prone way is to get it from the config file line. It will look something like the following near the bottom of the file:

<FontColorControl Name="fccDataGrid" ForeColor="-1447447" BackColor="-15790319" Font="Calibri Light" Style="Regular" Size="9.75" />

It looks like you have some custom DPI scaling happening, but I don't think that's the issue.

mastk0 commented 9 months ago

I couldn't figure out how to export the *.act file. However, upon hearing about the DPI issue, I tried the following, and the problem was resolved. Thank you!

Compatibility of Advanced Combat Tracker.exe → Change DPI settings to High → Set 'Override high DPI scaling behavior' to 'Application' as shown in the screenshot, under 'Scaling performed by:'

スクリーンショット 2024-01-18 110958 0002

Reference information: ・ACT settings remain at their default configuration. (Fonts and colors have all been reset) ・OS is Windows 11 23H2 (OS Build 22631.3007) ・The monitor used is a 4K display.

EQAditu commented 9 months ago

It would have been the following: image

I wonder why the DPI scaling would make things invisible, though. I noticed that the Latin letters were rather too big for the rows, which made me think of DPI scaling to begin with... I wonder if katakana/kanji needed more room to render vertically at that font size... and the layout decided to push it to another line that didn't show up?

mastk0 commented 9 months ago

The *.act file is here. Does this seem sufficient for reproduction?

MultipleEncounters.zip

EQAditu commented 7 months ago

This problem appears to be specific to running Hojoring plugins. They load the WPF UI framework into ACT which overrides how DPI settings are handled. When DPI settings are at default, this issue appears. Overriding DPI settings like you have done will fix this issue. Not using Hojoring will also fix this issue no matter what DPI settings are used.

Maybe having ACT include DPI aware overrides will help, but I'm concerned this will change how ACT looks for some people when they were not expecting it.

mastk0 commented 7 months ago

I appreciate the investigation. I do have Hojoring installed, so that's probably the cause. As long as I know the reason, it's fine!

EQAditu commented 2 months ago

ACT's manifest now sets a DPI scaling mode so overrides shouldn't be necessary.