EQAditu / AdvancedCombatTracker

Advanced Combat Tracker
https://advancedcombattracker.com
118 stars 25 forks source link

Open source the Advanced Combat Tracker application #95

Open FreedomFaighter opened 7 months ago

FreedomFaighter commented 7 months ago

GammaJul and TriNet core

are both available and can be submoduled into the build instead of providing them with the installation application

EQAditu commented 7 months ago

This is really a side topic, but I've wanted to move the G15/G19 code into a plugin because I don't think many people use it anymore.

Otherwise this topic comes up in Discord fairly often and the answer would be the same here. Ravahn makes the best points that I want to illustrate.

image

It might sound like more people might reduce work for others... but as the person that would have to manage the change requests and tell people that I don't want the project to head that way... it's a lot of extra work managing people that I don't want to do.

FreedomFaighter commented 7 months ago

usually this issue is providing them in closed form without a link to the source, a way around this is usually using NuGet packages during compilation or downloading them directly from the distribution site and not providing them yourself

example of a project with NuGet adding the DataFlow library for asyncronous processing

FreedomFaighter commented 7 months ago

Your mention of using the source code in other projects that has been solved by moving the commitment history over with the reflog so the original changes do not disappear in the project which is using that code

FreedomFaighter commented 6 months ago

@OstlerDev may be able to help me see if I am not look at this issue correctly and it may need to be closed